Added script to clean up test lib directory #6492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llxia
reviewed
Aug 8, 2025
| node { | ||
| def repo = params.ADOPTOPENJDK_REPO | ||
| def branch = params.ADOPTOPENJDK_BRANCH | ||
| def dependencyDir = params.DEPENDENCY_DIR ? params.DEPENDENCY_DIR : 'externalDependency' |
There was a problem hiding this comment.
def dependencyDir = params.DEPENDENCY_DIR ?: 'externalDependency'
| } | ||
|
|
||
| def platformMap = [ | ||
| 'amac' : '(ci.role.test||ci.role.test.fips)&&hw.arch.aarch64&&(sw.os.osx||sw.os.mac)', |
There was a problem hiding this comment.
Could you fix the indentation?
| @@ -0,0 +1,60 @@ | |||
| node { | |||
There was a problem hiding this comment.
Did we use node in the original script?
There was a problem hiding this comment.
No lan
There was a problem hiding this comment.
If the node is not required, then we should not add it.
|
This is the initial check-in for the script from the job config to git repo. |
|
@Amrutha-Kanhirathingal please add |
Amrutha-Kanhirathingal
force-pushed
the
cleanupExternalTestlib
branch
from
bba0ff1 to
2d5dd41
Compare
Amrutha-Kanhirathingal
force-pushed
the
cleanupExternalTestlib
branch
2 times, most recently
from
bded437 to
d5cbc9e
Compare
llxia
reviewed
Aug 13, 2025
Comment on lines
4
to
11
| 'amac' : '(ci.role.test||ci.role.test.fips)&&hw.arch.aarch64&&(sw.os.osx||sw.os.mac)', | ||
| 'xmac' : '(ci.role.test||ci.role.test.fips)&&hw.arch.x86&&sw.os.mac', | ||
| 'xlinux' : '(ci.role.test||ci.role.test.fips)&&hw.arch.x86&&sw.os.linux', | ||
| 'plinux' : '(ci.role.test||ci.role.test.fips)&&hw.arch.ppc64le&&sw.os.linux', | ||
| 'zlinux' : '(ci.role.test||ci.role.test.fips)&&hw.arch.s390x&&sw.os.linux', | ||
| 'alinux' : '(ci.role.test||ci.role.test.fips)&&hw.arch.aarch64&&sw.os.linux', | ||
| 'win' : '(ci.role.test||ci.role.test.fips)&&hw.arch.x86&&sw.os.windows', | ||
| 'aix' : '(ci.role.test||ci.role.test.fips)&&hw.arch.ppc64&&sw.os.aix' |
related: runtimes/automation/issues/166 Signed-off-by:Amrutha Kanhirathingal <Amrutha.Kanhirathingal@ibm.com>
Amrutha-Kanhirathingal
force-pushed
the
cleanupExternalTestlib
branch
from
d5cbc9e to
1989029
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added script to clean up test lib directory (externalDependencyDir/testDependencyDir)