Skip to content

Conversation

@calderast
Copy link

Apply some of Alpine's patches, changes from the original commit, and additional fixes for Alpine Linux build support on jdk8u.

This PR is identical to #8 (excluding whitespace changes) with a cleaner commit history.

@calderast
Copy link
Author

calderast commented Mar 8, 2022

New pipeline run against this branch for Alpine Linux (https://ci.adoptopenjdk.net/job/jdk8-alpine-linux-x64-hotspot/59/)

From #8:
Pipeline run for all other platforms (https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/2015/)
The above run failed on Windows x64 due to a pipeline issue, passing Windows x64 re-run here (https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/2017/)

@calderast
Copy link
Author

calderast commented Mar 8, 2022

One of the whitespace changes from the previous PR caused a separator error in sa.make - it's been fixed now, so this should be good to go

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches previous PR in source diff and is cleaner in commit messages. Passes builds on all platforms and AQAVit & TCK

@gdams
Copy link
Member

gdams commented Mar 10, 2022

Final build pipeline against correct branch for sanity reasons: https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk8-pipeline/2035/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants