Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build JDK11u 11.0.9 (or a variant) with Shenandoah #2114

Closed
bric3 opened this issue Oct 5, 2020 · 8 comments · Fixed by #2125
Closed

Build JDK11u 11.0.9 (or a variant) with Shenandoah #2114

bric3 opened this issue Oct 5, 2020 · 8 comments · Fixed by #2125
Assignees
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Milestone

Comments

@bric3
Copy link

bric3 commented Oct 5, 2020

Hello,

Do you plan to release a jdk11u build with Shenandoah ? As you are certainly aware Shenandoah was back-ported this summer, it just need to be activated in the build.

While the modification in this file is likely straightforward, it has certainly implications which I do not grasp. Wether to include Shanandoah in the default build may be something up to debate, but in the case it's a no I think that shipping a JDK11u variant with Shenandoah could be appreciated, I certainly would.

Cheers,
Thank you for this project !!!

@jerboaa jerboaa changed the title Build JDK11u 110.0.9 (or a variant) with Shenandoah Build JDK11u 11.0.9 (or a variant) with Shenandoah Oct 5, 2020
@karianna karianna added this to TODO in temurin-build via automation Oct 5, 2020
@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Oct 5, 2020
@karianna
Copy link
Contributor

karianna commented Oct 5, 2020

IMO we should include it as a default, it's mainline code, and fully supported there.

@aahlenst
Copy link
Contributor

aahlenst commented Oct 5, 2020

Agreed. Do we need to discuss that in a TSC call, @karianna?

@karianna
Copy link
Contributor

karianna commented Oct 5, 2020

I'll just make it a quick poll vote I think.

@kittylyst
Copy link

I would be in favour of Shenandoah being included as a default if you're looking for community opinions :)

@karianna
Copy link
Contributor

karianna commented Oct 6, 2020

So looking at this more closely, I think the nightlies just have this automatically.

@bric3 Can you try a https://adoptopenjdk.net/nightly.html build (Java 11) and let us know if that works for you?

@bric3
Copy link
Author

bric3 commented Oct 6, 2020

@karianna Using the macOs build at least didn't. I'll test a linux one in a minute. EDIT it the same with the linux build. (Both dated from October 5).

$ tar xf OpenJDK11U-jdk_x64_mac_hotspot_2020-10-05-14-54.tar.gz
$ cd jdk-11.0.9+10/Contents/Home/bin
$ ./java --version
openjdk 11.0.9 2020-10-20
OpenJDK Runtime Environment Hotspot (build 11.0.9+10-202010050013)
OpenJDK 64-Bit Server VM Hotspot (build 11.0.9+10-202010050013, mixed mode)
$ ./java -XX:+PrintFlagsFinal -XX:+UseShenandoahGC --version | less
Unrecognized VM option 'UseShenandoahGC'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Anyway on my own build from openjdk-jdk11u I had to explicitly activate it (--with-jvm-features=shenandoahgc), but this was a few days ago.

openjdk 11.0.9-internal 2020-10-20
OpenJDK Runtime Environment (build 11.0.9-internal+0-adhoc.bric3.openjdk-jdk11u)
OpenJDK 64-Bit Server VM (build 11.0.9-internal+0-adhoc.bric3.openjdk-jdk11u, mixed mode)

@karianna karianna self-assigned this Oct 7, 2020
@karianna karianna added this to the October 2020 milestone Oct 7, 2020
@karianna karianna moved this from TODO to In Progress in temurin-build Oct 7, 2020
@karianna karianna linked a pull request Oct 7, 2020 that will close this issue
temurin-build automation moved this from In Progress to Done Oct 13, 2020
karianna added a commit that referenced this issue Oct 13, 2020
* Add Shenandoah build config arg for Java 11 platforms that support it

* Attempt to make Shenandoah build flag as a build.sh concern

* Fixes after sxa review

* Fixes after Andreas review
@orionll
Copy link

orionll commented Oct 25, 2020

I'm sorry but I don't see Shenandoah in AdoptOpenJDK 11.0.9. What am I doing wrong?

C:\Soft\jdk-11\bin>java --version
openjdk 11.0.9 2020-10-20
OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.9+11)
OpenJDK 64-Bit Server VM AdoptOpenJDK (build 11.0.9+11, mixed mode)

C:\Soft\jdk-11\bin>java -XX:+UseShenandoahGC --version
Unrecognized VM option 'UseShenandoahGC'
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

@aahlenst
Copy link
Contributor

@orionll #2176

@adoptium adoptium locked as resolved and limited conversation to collaborators Oct 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
No open projects
temurin-build
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants