Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client VM to builds for Linux arm32 platform #1078

Merged
merged 1 commit into from
May 11, 2019
Merged

Add Client VM to builds for Linux arm32 platform #1078

merged 1 commit into from
May 11, 2019

Conversation

jgneff
Copy link
Contributor

@jgneff jgneff commented May 10, 2019

Closes #1070

DCO 1.1 Signed-off-by: John Neffenger john@status6.com

Closes #1070

DCO 1.1 Signed-off-by: John Neffenger <john@status6.com>
@adoptopenjdk-github-bot
Copy link
Contributor

Can one of the admins verify this patch?

@jgneff
Copy link
Contributor Author

jgneff commented May 10, 2019

The one-line change appears to work.

Before

The current AdoptOpenJDK build of JDK 12 for Linux arm32 includes only the Server VM and ignores the option to run the Client VM:

john@koboa:~/opt$ jdk-12.0.1+12/bin/java -version
openjdk version "12.0.1" 2019-04-16
OpenJDK Runtime Environment AdoptOpenJDK (build 12.0.1+12)
OpenJDK Server VM AdoptOpenJDK (build 12.0.1+12, mixed mode)
john@koboa:~/opt$ jdk-12.0.1+12/bin/java -client -version
openjdk version "12.0.1" 2019-04-16
OpenJDK Runtime Environment AdoptOpenJDK (build 12.0.1+12)
OpenJDK Server VM AdoptOpenJDK (build 12.0.1+12, mixed mode)

The Server VM fails to run because of the bug mentioned in the #1070 issue report:

john@koboa:~/src/epd-javafx$ ~/opt/jdk-12.0.1+12/bin/java -client ...
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGILL (0x4) at pc=0x2b8664c4, pid=10935, tid=10936
#
# JRE version: OpenJDK Runtime Environment (12.0.1+12) (build 12.0.1+12)
# Java VM: OpenJDK Server VM (12.0.1+12, mixed mode, serial gc, linux-arm)

... [fails] ...

After

With this change, the AdoptOpenJDK build of JDK 12 for Linux arm32 includes both the Client and Server VMs:

john@koboa:~/opt$ jdk-12.0.1+12-1070/bin/java -version
openjdk version "12.0.1" 2019-04-16
OpenJDK Runtime Environment AdoptOpenJDK (build 12.0.1+12-201905092028)
OpenJDK Server VM AdoptOpenJDK (build 12.0.1+12-201905092028, mixed mode)
john@koboa:~/opt$ jdk-12.0.1+12-1070/bin/java -client -version
openjdk version "12.0.1" 2019-04-16
OpenJDK Runtime Environment AdoptOpenJDK (build 12.0.1+12-201905092028)
OpenJDK Client VM AdoptOpenJDK (build 12.0.1+12-201905092028, mixed mode)

The Server VM fails as shown above, but now the Client VM can be run as an alternative:

john@koboa:~/src/epd-javafx$ ~/opt/jdk-12.0.1+12-1070/bin/java -client

... [works] ...

Sizes

The sizes below are those reported by the du command using the -s --si options for MB and the -sb options for bytes.

The size of the installed JDK on disk increases by 12 MB (12,149,360 bytes), an increase of about four percent. The size with just the Server VM is currently 300 MB (298,524,733 bytes). Adding the Client VM increases the size to 312 MB (310,674,093 bytes). The change in size is found predominantly in the following files:

Path Current Size New Size Difference
jmods/java.base.jmod 18,557,545 22,419,847 3,862,302
lib/client/* 0 8,162,226 8,162,226

@karianna karianna added this to the May 2019 milestone May 11, 2019
@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label May 11, 2019
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ARM Cortex-A8 cores with Client VM
3 participants