Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unusing types at base #26

Merged
merged 3 commits into from Dec 3, 2019
Merged

Conversation

NicholasWon47
Copy link
Contributor

No description provided.

- remove Callable, Iterator, Tuple
- remove type Callable
@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #26 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #26   +/-   ##
========================================
  Coverage    95.08%   95.08%           
========================================
  Files           14       14           
  Lines          468      468           
========================================
  Hits           445      445           
  Misses          23       23
Impacted Files Coverage Δ
adopy/base/_task.py 100% <100%> (ø) ⬆️
adopy/base/_engine.py 93.57% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64e56a4...3037301. Read the comment docs.

@NicholasWon47
Copy link
Contributor Author

Hope this help. btw your code is quite neat 👍

happy to contribute! :)

@JaeyeongYang JaeyeongYang merged commit ac50e05 into adopy:develop Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants