Skip to content
Permalink
Browse files

Feature/hhe added plugin for javadocs

  • Loading branch information...
Hryhorii Hevorkian authored and DG0lden committed Mar 6, 2019
1 parent 72cd64b commit 827d286c7ef4699ad92f8f88092cc4300e18947d
@@ -352,7 +352,7 @@ check_javadoc_java8:
- jabba use $JAVA_VERSION
- cat /sys/fs/cgroup/memory/memory.limit_in_bytes
- java -XX:+PrintFlagsFinal -version | grep -Ei "maxheapsize|maxram"
- mvn -Dmaven.test.skip=true verify javadoc:javadoc
- mvn -Dmaven.test.skip=true -Pjavadoc verify javadoc:javadoc
artifacts:
paths:
- "**/target/site/*"
@@ -369,7 +369,7 @@ check_javadoc_java11:
- jabba use $JAVA_VERSION
- cat /sys/fs/cgroup/memory/memory.limit_in_bytes
- java -XX:+PrintFlagsFinal -version | grep -Ei "maxheapsize|maxram"
- mvn -Dmaven.test.skip=true verify javadoc:javadoc
- mvn -Dmaven.test.skip=true -Pjavadoc verify javadoc:javadoc

unit_tests_java8:
<<: *java_tests
@@ -49,6 +49,13 @@ public void doFillAccess(List<AccountInfo> info, TypeAccess typeAccess) {

/**
* According to specification if user gives access to TRANSACTION or BALANCE the access to accounts is granted automatically
*
* @param aspspAccountId Bank specific account ID
* @param accountIdentifier Account-Identifier
* @param resourceId This identification is denoting the addressed account
* @param currency ISO 4217 currency code
* @param accountReferenceType Type of the account reference
* @param typeAccess Type access
*/
private void addAccountAccess(String aspspAccountId, String accountIdentifier, String resourceId, Currency currency, AccountReferenceType accountReferenceType, TypeAccess typeAccess) {
accountAccesses.add(new AspspAccountAccess(accountIdentifier, typeAccess, accountReferenceType, currency, resourceId, aspspAccountId));
@@ -385,7 +385,8 @@ private void savePaymentData(PisCommonPaymentData pisCommonPayment, PisCommonPay
/**
* Creates PIS consent authorisation entity and stores it into database
*
* @param paymentData PIS payment data, for which authorisation is performed
* @param paymentData PIS payment data, for which authorisation is performed
* @param request needed parameters for creating PIS authorisation
* @return PisAuthorization
*/
private PisAuthorization saveNewAuthorisation(PisCommonPaymentData paymentData, CreatePisAuthorisationRequest request) {
31 pom.xml
@@ -154,6 +154,7 @@
<maven-enforcer-plugin.version>1.4.1</maven-enforcer-plugin.version>
<maven-surefire-plugin.version>2.22.1</maven-surefire-plugin.version>
<maven-compiler-plugin.version>3.7.0</maven-compiler-plugin.version>
<maven-checkstyle-plugin.version>3.0.0</maven-checkstyle-plugin.version>

<jackson.version>2.9.8</jackson.version>

@@ -601,9 +602,6 @@ Use it manually to generate javadocs. Don't commit it
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven-surefire-plugin.version}</version>
<configuration>
<useSystemClassLoader>false</useSystemClassLoader>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
@@ -753,6 +751,33 @@ Use it manually to generate javadocs. Don't commit it
</plugins>
</build>
</profile>
<profile>
<id>javadoc</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven-checkstyle-plugin.version}</version>
<configuration>
<failsOnError>false</failsOnError>
<failOnViolation>true</failOnViolation>
<excludes>**/de/adorsys/psd2/xs2a/exception/model/**</excludes>
<configLocation>qa/javadoc/javadoc-checkstyle.xml</configLocation>
</configuration>
<executions>
<execution>
<id>check_javadoc</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>
<distributionManagement>
<repository>
@@ -87,9 +87,10 @@ private static QCStatement readQCStatement(byte[] extensionValue) throws Certifi
.orElseThrow(() -> new CertificateValidationException(CertificateErrorMsgCode.CERTIFICATE_INVALID.toString()));
}

/** Iterate the list of qcStatements and try to find teh EtsiPsd2 statenent
/**
* Iterate the list of qcStatements and try to find the EtsiPsd2 statement
*
* @param qcStatements
* @param qcStatements input parameter to get the EtsiPsd2
* @return Etsi Pds2 Statement or Optional.empty if not found
*/
private static Optional<QCStatement> getEtsiPsd2QcStatement(ASN1Sequence qcStatements) {
@@ -106,12 +107,13 @@ private static QCStatement readQCStatement(byte[] extensionValue) throws Certifi
return Optional.of(QCStatement.getInstance(filteredIterator.next()));
}

/** This is a fallback for the cases where a single qcStatement with PSD2 items is added without wrapping it
/**
* This is a fallback for the cases where a single qcStatement with PSD2 items is added without wrapping it
* in a SEQUENCE.
*
* @param qcStatements
* @param qcStatements input parameter to get a single QC statement.
* @return QCStatement
* @throws CertificateValidationException
* @throws CertificateValidationException in case of wrong statement type in psd2 certificate
*/
private static QCStatement getSingleQcStatement(ASN1Sequence qcStatements) throws CertificateValidationException {
// We have a single entity with oid and value direct
@@ -0,0 +1,19 @@
<?xml version="1.0"?>
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.2//EN"
"http://www.puppycrawl.com/dtds/configuration_1_2.dtd">

<module name="Checker">
<module name="TreeWalker">
<module name="JavadocMethod">
<property name="minLineCount" value="5"/>
<property name="allowMissingJavadoc" value="true"/>
<property name="allowMissingParamTags" value="false"/>
<property name="allowMissingReturnTag" value="false"/>
</module>
<module name="JavadocStyle">
<property name="checkEmptyJavadoc" value="false"/>
<property name="checkFirstSentence" value="false"/>
</module>
</module>
</module>
@@ -33,6 +33,7 @@
* Checks whether endpoint is accessible for current authorisation
*
* @param authorisationId ID of authorisation process
* @param authorisationType payment initiation or cancellation
* @return <code>true</code> if accessible. <code>false</code> otherwise.
*/
public boolean isEndpointAccessible(String authorisationId, PaymentAuthorisationType authorisationType) {
@@ -31,6 +31,7 @@
<properties>
<springfox.version>2.9.2</springfox.version>
<pmd.skip>true</pmd.skip> <!-- This module uses generated sources, that we cannot adopt -->
<checkstyle.skip>true</checkstyle.skip><!-- Checkstyle for javadocs is also useless here -->
</properties>

<dependencies>

0 comments on commit 827d286

Please sign in to comment.
You can’t perform that action at this time.