Fluent setter #22
Merged
Fluent setter #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi, thanks for the contribution. Before merging this I would love to have some kind of configuration where I can change the behaviour of this with something like 0 = disabled So that people don't always have to answer this question. Thanks |
This commit adds g:php_refactoring_make_setter_fluent which is by default 0. Possible values are: 0 - Disabled 1 - Enabled 2 - Prompt Other - Error
Collaborator
Author
|
Hi, added that configuration option in f91c424. Hope it works. |
adoy
approved these changes
Nov 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this plugin today while doing some massive refactoring and found it extremely useful.
I use fluent setters quite often. This PR adds another prompt to provide the user with the option to have a
return $this;statement in the setter method.