Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add python3.12 drop python3.7 #112

Merged

Conversation

maxzhenzhera
Copy link
Contributor

Closes #111

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Merging #112 (b49bb51) into main (0e7adb3) will increase coverage by 0.30%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   96.93%   97.24%   +0.30%     
==========================================
  Files          67       66       -1     
  Lines        2320     2284      -36     
  Branches      336      327       -9     
==========================================
- Hits         2249     2221      -28     
+ Misses         61       54       -7     
+ Partials       10        9       -1     
Files Coverage Δ
di/_container.py 93.85% <ø> (-0.03%) ⬇️
di/_utils/concurrency.py 100.00% <ø> (ø)
di/_utils/inspect.py 100.00% <ø> (ø)
di/_utils/types.py 100.00% <100.00%> (ø)
di/api/dependencies.py 100.00% <100.00%> (ø)
di/api/executor.py 100.00% <100.00%> (ø)
di/typing.py 100.00% <100.00%> (ø)
docs_src/bind_as_a_dep.py 100.00% <100.00%> (ø)
docs_src/solved_dependent.py 100.00% <100.00%> (ø)
tests/docs/test_sharing_example.py 100.00% <ø> (ø)
... and 3 more

... and 2 files with indirect coverage changes

@maxzhenzhera
Copy link
Contributor Author

Omg, I made smth bad for python3.8
I think it is a question of imports

@maxzhenzhera
Copy link
Contributor Author

maxzhenzhera commented Oct 4, 2023

Hmm, I believed that get_origin, get_args had become available in python3.8 and it is safe to use them just from std...)

@adriangb
Copy link
Owner

adriangb commented Oct 4, 2023

Hmm, I believed that get_origin, get_args had become available in python3.8 and it is safe to use them just from std...)

I don't think so: https://github.com/python/typing_extensions/blob/b6318ab4b4777a38b468eef7aae97061c283eb8d/src/typing_extensions.py#L1175-L1177

@maxzhenzhera
Copy link
Contributor Author

@maxzhenzhera
Copy link
Contributor Author

@adriangb Please, review

@adriangb adriangb merged commit 73cfde1 into adriangb:main Oct 9, 2023
17 checks passed
@maxzhenzhera maxzhenzhera deleted the feature/add-python3.12-drop-python3.7 branch October 9, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python3.12
3 participants