refactor!: rework app router relationship #32
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change:
Mount
,Host
, etc.App
since there can only ever be 1 lifespan and there can only be 1App
.As part of this,
App
no longer inherits fromStarlette
andRouter
no longer inherits from its counterpart in Starlette.This both simplifies things and complicates them a bit, but it does give us the opportunity to do a bit of cleanup and performance optimization (slots, removing lifespan wrappers and making routing sans-io)
There are obviously cons to this though. I might let this stew a bit and see.
Here are the benchmark numbers using the benchmarks in
/benchmark
:So it looks like this is a pretty solid +10% performance boost for simple scenarios