Documentation tweak #1

Merged
merged 1 commit into from Nov 19, 2012

Conversation

Projects
None yet
3 participants
@skington
Contributor

skington commented Jan 16, 2012

It took me a while digging through the code before I realised that saying

sub startup_foo : Tests(startup) {
...
}

wasn't going to work - the Tests attribute only fills in no_plan if there are no arguments, and there's going to be an argument if this is a startup method.

Arguably it should Do The Right Thing, but that breaks encapsulation somewhat.

@adrianh

This comment has been minimized.

Show comment Hide comment
@adrianh

adrianh Jan 17, 2012

Owner

Thanks. I'll get it in the next release.

Ta,

Adrian

On 16 Jan 2012, at 18:58, Sam Kington wrote:

It took me a while digging through the code before I realised that saying

sub startup_foo : Tests(startup) {
...
}

wasn't going to work - the Tests attribute only fills in no_plan if there are no arguments, and there's going to be an argument if this is a startup method.

Arguably it should Do The Right Thing, but that breaks encapsulation somewhat.

You can merge this Pull Request by running:

git pull https://github.com/skington/test-class master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • Documentation clarification.

-- File Changes --

M lib/Test/Class.pm (9)

-- Patch Links --

https://github.com/adrianh/test-class/pull/1.patch
https://github.com/adrianh/test-class/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

http://quietstars.com adrianh@quietstars.com twitter.com/adrianh
t. +44 (0)7752 419080 skype adrianjohnhoward del.icio.us/adrianh

Owner

adrianh commented Jan 17, 2012

Thanks. I'll get it in the next release.

Ta,

Adrian

On 16 Jan 2012, at 18:58, Sam Kington wrote:

It took me a while digging through the code before I realised that saying

sub startup_foo : Tests(startup) {
...
}

wasn't going to work - the Tests attribute only fills in no_plan if there are no arguments, and there's going to be an argument if this is a startup method.

Arguably it should Do The Right Thing, but that breaks encapsulation somewhat.

You can merge this Pull Request by running:

git pull https://github.com/skington/test-class master

Or you can view, comment on it, or merge it online at:

#1

-- Commit Summary --

  • Documentation clarification.

-- File Changes --

M lib/Test/Class.pm (9)

-- Patch Links --

https://github.com/adrianh/test-class/pull/1.patch
https://github.com/adrianh/test-class/pull/1.diff


Reply to this email directly or view it on GitHub:
#1

http://quietstars.com adrianh@quietstars.com twitter.com/adrianh
t. +44 (0)7752 419080 skype adrianjohnhoward del.icio.us/adrianh

Ovid added a commit that referenced this pull request Nov 19, 2012

@Ovid Ovid merged commit 424619b into adrianh:master Nov 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment