Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml processor does not support xliff:g elements #31

Open
dalewking opened this issue Nov 27, 2023 · 1 comment
Open

xml processor does not support xliff:g elements #31

dalewking opened this issue Nov 27, 2023 · 1 comment
Labels
codegen: android-xml Codegen from Android String Resources conversion issue enhancement New feature or request

Comments

@dalewking
Copy link

It is a common practice to embed elements like this in string files to provide clues to translators:

    <string name="time_range_format"><xliff:g id="startTime" example="1:30 PM">%1$s</xliff:g> - <xliff:g id="endTime" example="3:30 PM">%2$s</xliff:g></string>

But the xml processor does not support them and gives an error:

[ksp] com.gitlab.mvysny.konsumexml.KonsumerException: line 11 column 80 at null file:///Users/dalewking/Downloads/Foo/composeApp/src/strings/values-it/strings.xml, in element : Expected text but got START_ELEMENT: {urn:oasis:names:tc:xliff:document:1.2}g
@DevNatan DevNatan added enhancement New feature or request codegen: android-xml Codegen from Android String Resources conversion issue labels Nov 27, 2023
@dalewking
Copy link
Author

When you do support these elements it would be nice if the id were used as the function parameter name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen: android-xml Codegen from Android String Resources conversion issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dalewking @DevNatan