New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework OpenSSL library detection #303

Merged
merged 1 commit into from May 11, 2018

Conversation

Projects
None yet
2 participants
@tadeboro
Copy link
Contributor

tadeboro commented May 11, 2018

Currently, X509_check_host function is always marked as missing, since
AC_CHECK_FUNCS is missing linker flags for libssl and libcrypto.

Culprit for this is the PKG_CHECK_MODULES call that does not add
libraries to the link arguments that configure uses to create function
tests, which in turn makes function check fail.

To remedy the situation, this commit replaces PKG_CHECK_MODULES with
two AC_CHECK_LIB calls (one for libcrypto and one for libssl) that
properly populate configure linker flags.

Rework OpenSSL library detection
Currently, X509_check_host function is always marked as missing, since
AC_CHECK_FUNCS is missing linker flags for libssl and libcrypto.

Culprit for this is the PKG_CHECK_MODULES call that does not add
libraries to the link arguments that configure uses to create function
tests, which in turn makes function check fail.

To remedy the situation, this commit replaces PKG_CHECK_MODULES with
two AC_CHECK_LIB calls (one for libcrypto and one for libssl) that
properly populate configure linker flags.

@DimitriPapadopoulos DimitriPapadopoulos merged commit 79f52ef into adrienverge:master May 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@DimitriPapadopoulos

This comment has been minimized.

Copy link
Collaborator

DimitriPapadopoulos commented May 12, 2018

I had to revert to keep taking into account PKG_CONFIG_PATH on macOS.

@tadeboro tadeboro deleted the xlab-si:fix-x509_check_host-detection branch May 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment