New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PKG_CHECK_MODULES compiler/linker flags #307

Merged
merged 1 commit into from May 16, 2018

Conversation

Projects
None yet
3 participants
@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented May 13, 2018

The OPENSSL_CFLAGS and OPENSSL_LIBS flags were taken into account in
Makefile.am, but not in configure.ac when testing for X509_check_host.

Fixes #304.

@tadeboro

This comment has been minimized.

Copy link
Contributor

tadeboro commented May 13, 2018

I think it would be better to use #306 instead of this pull request, since OpenSSL < 1.0.2 is not maintained anymore.

@DimitriPapadopoulos DimitriPapadopoulos requested a review from mrbaseman May 13, 2018

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the DimitriPapadopoulos:PKG_CHECK_MODULES branch 2 times, most recently from 349e4ab to ab43d8b May 15, 2018

@DimitriPapadopoulos

This comment has been minimized.

Copy link
Collaborator

DimitriPapadopoulos commented May 15, 2018

While OpenSSL < 1.0.2 is not maintained any more, some Linux distributions based on OpenSSL 0.9.8 have still not reached EOL:

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the DimitriPapadopoulos:PKG_CHECK_MODULES branch 2 times, most recently from ab43d8b to fe6a86d May 15, 2018

@@ -18,7 +18,7 @@ AC_CANONICAL_HOST
AM_SILENT_RULES([yes])

# Checks for libraries.
PKG_CHECK_MODULES(OPENSSL, [libcrypto libssl])
PKG_CHECK_MODULES(OPENSSL, [libcrypto >= 0.9.8 libssl >= 0.9.8], [], [AC_MSG_ERROR([Cannot find OpenSSL 0.9.8 or better.])])

This comment has been minimized.

@mrbaseman

mrbaseman May 16, 2018

Collaborator

maybe "0.9.8 or higher" sounds better? apart from that it looks good to me. I didn't test if it actually solves #304 but I assume you have already verified that

Use PKG_CHECK_MODULES compiler/linker flags
The OPENSSL_CFLAGS and OPENSSL_LIBS flags were taken into account in
Makefile.am, but not in configure.ac when testing for X509_check_host.

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the DimitriPapadopoulos:PKG_CHECK_MODULES branch from fe6a86d to 6396b87 May 16, 2018

@DimitriPapadopoulos DimitriPapadopoulos merged commit e625953 into adrienverge:master May 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DimitriPapadopoulos DimitriPapadopoulos deleted the DimitriPapadopoulos:PKG_CHECK_MODULES branch May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment