Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some edits from me #31

Merged
merged 1 commit into from Sep 19, 2016
Merged

Some edits from me #31

merged 1 commit into from Sep 19, 2016

Conversation

dfm
Copy link
Collaborator

@dfm dfm commented Sep 14, 2016

I've started editing the paper a bit. Overall, it seems good but I think that a lot of the language is too strong. @davidwhogg keeps saying "provably correct" but it's never demonstrated convincingly. I don't think we want to prove this so I'd just cut this terminology entirely.

Feel free to merge this but I'll keep editing.

@davidwhogg
Copy link
Collaborator

I agree, but if it isn't for our demonstrable correctness, why not just use DNEST?

@dfm
Copy link
Collaborator Author

dfm commented Sep 15, 2016

Exactly. Convince me :-)

@adrn
Copy link
Owner

adrn commented Sep 19, 2016

@dfm I made an issue that I think explains your concerns #32

@adrn
Copy link
Owner

adrn commented Sep 19, 2016

@dfm Also, RE: "verify the likelihood function is unimodal" and your comment. Just to clarify, we mean that if you have many, many precise observations, your likelihood should be unimodal. I can't tell if your point is that this statement is incorrect or if you are thinking about data sets with only few observations.

@dfm
Copy link
Collaborator Author

dfm commented Sep 19, 2016

I just meant that your data will need to have infinite signal-to-noise and be very precisely sampled to actually be perfectly unimodal. There's a definition of "unimodal enough" that's missing. For example, at the edge cases, different realizations of the simple MC will come to different conclusions about whether or not a posterior is unimodal. I think that the language is a little too strong currently.

@adrn
Copy link
Owner

adrn commented Sep 19, 2016

Yea, got it!

@adrn adrn merged commit 0daeab8 into master Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants