Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgrep
command in pgrep-mode - gonna trust the user on that :)version_cmd
because it's not needed there (only numbers are encoded, not strings)get_symbol_offset
because they are constants throughout the project.I tested it with a PHP binary I put in
/tmp/php''$(echo > yyy)
. Works like a charm (and noyyy
file created in cwd, but neither does in master).Also tested with
/tmp/php$(echo > abc)
, noabc
file created in cwd.On master - both don't work &
abc
is created.Also dropped a small commit that fixes a missing s(n)printf overflow (like 3120b8d)
Closes: #81