Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 40 million developers.
Sign up
- Boston, MA
- https://aduh95.github.io
Pinned
687 contributions in the last year
Activity overview
Contributed to
aduh95/newsletter-template-builder,
aduh95/aduh95.github.io,
aduh95/async-jsx
and 5 other
repositories
Contribution activity
January 2020
Created a pull request in nodejs/node that received 7 comments
[v12 backport] lib: no need to strip BOM or shebang for scripts
Node.js v12's V8 version has been bumped from 7.4 straight to 7.8 and missed 702331b (which was introduced with 7.5 upgrade). EDIT: I get this part…
+87
−117
•
7
comments
Created an issue in nodejs/modules that received 4 comments
import(cjs) messes with module.parent
Some packages use a check on module.parent to know if they are launched from CLI or required by another module:
// module.cjs
if (!module.parent) t…
4
comments