Skip to content

APIC-830 collapsable example panel #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 4, 2022
Merged

APIC-830 collapsable example panel #26

merged 16 commits into from
Feb 4, 2022

Conversation

@alexpmule
Copy link
Contributor

@alexpmule alexpmule commented Jan 31, 2022 •
edited
Loading

Description

Examples can be very long and have to be scrolled in order to reach sections bellow them. To make the navigation easier, they should be collapsible.

Ticker in Jira

UI screenshots with changes

Screen.Recording.2022-02-04.at.10.48.08.mov

Issue type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • The created branch follows branching convention: fix/AAP-x/, feat/AAP-x/, test/AAP-x/* or chore/AAP-x/*
  • The commit messages have the Jira ticket.
  • The PR is rebased with base branch.
  • I added tests.
  • I validated the fix manually.
  • I have performed a self-review of my own code
  • This change requires documentation update
  • This change includes library / dependency update.
  • My changes generate no new warnings

@alexpmule alexpmule self-assigned this Feb 2, 2022
@alexpmule
APIC-830 Code review
d7de565 
- Add custom set and getter and update render
@alexpmule alexpmule marked this pull request as ready for review February 2, 2022 18:40
carowright
carowright reviewed Feb 4, 2022
View reviewed changes
Copy link
Contributor

@carowright carowright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! It looks very good 🚀

I noticed that the cursor pointer is only appearing on icon hover, shouldn’t it be for all the Example label section?

alexpmule and others added 3 commits February 4, 2022 10:08
@alexpmule @carowright
Update test/api-resource-example-document.test.js
bf14e27 
Co-authored-by: Carolina Wright <carolina.wright@mulesoft.com>
@alexpmule @carowright
Update test/api-resource-example-document.test.js
eed7f52 
Co-authored-by: Carolina Wright <carolina.wright@mulesoft.com>
@alexpmule
APIC-830 Add cursor pointer to the header of example-panel
4f60c94
@alexpmule
Copy link
Contributor Author

alexpmule commented Feb 4, 2022

Great work! It looks very good 🚀

I noticed that the cursor pointer is only appearing on icon hover, shouldn’t it be for all the Example label section?

Because I don't found any behavior similar in other panel, When I put cursor pointer, It saw too different to others.

Talking with Jose(UX), he is accord with add cursor pointer, It is done

@alexpmule alexpmule requested a review from carowright February 4, 2022 13:51
carowright
carowright previously approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@carowright carowright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@alexpmule alexpmule merged commit 560b9c6 into master Feb 4, 2022
@alexpmule alexpmule deleted the feat/APIC-830-examples-should-be-collapsible branch February 4, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twoplustwoone twoplustwoone Awaiting requested review from twoplustwoone

1 more reviewer

@carowright carowright carowright approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexpmule alexpmule

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexpmule @carowright