Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming not OK Windows 11 #448

Closed
stefangroenew opened this issue Feb 2, 2022 · 8 comments
Closed

Theming not OK Windows 11 #448

stefangroenew opened this issue Feb 2, 2022 · 8 comments
Labels

Comments

@stefangroenew
Copy link

See image:

image

@jarrodek
Copy link
Member

jarrodek commented Feb 2, 2022

Looks like styles are not loaded. Is there an error message associated with this behavior in the developer console? You can access it through the application menu (View > Developer).
Yesterday I published a change with a critical bug fix. Please, confirm you have version 17.0.7.

@stefangroenew
Copy link
Author

Version: 17.0.7
Up to date

When I want to select another theme:

image

Developer tools:

image

@msbentley
Copy link

I also had this on linux - I loaded the themes manually (dark and light) from their respective github repos, but I still get overlapping UI elements/odd transparency as above.

@saper-2
Copy link

saper-2 commented Feb 4, 2022

Same here, no themes at all ☹️. Some element are transparent or black 😑...

How i can manually add themes?
I guessing that I have to copy from repo content of the appresources/themes/@advanced-rest-client folder but into which dir?
-- edited --
I had added themes using repo method, but those themes looks still "broken".

Win 21H1 & 21H2 same results.

theme1
theme2
theme3

@flopezre
Copy link

flopezre commented Feb 6, 2022

Confirmed on Windows 10 21H2

@Icosa2050
Copy link

Confirmed on Ubuntu 21.04 GNOME 3.38.5 X11

@jarrodek
Copy link
Member

jarrodek commented Feb 7, 2022

Thank you all for the details.
Since this morning, I have been investigating this, and I am nowhere close to the fix. It seems like Electron stopped reading files from the application archive at the initialization phase. Surprisingly, it all works elsewhere. It is hard to debug the problem because it only occurs when the application is packaged. I have to package it repeatedly every time I make a change, making it much longer to debug.
I'll update you when I figure out what is happening. In the meantime, I suggest installing v16 and disabling auto-update in the about screen.

@jarrodek
Copy link
Member

jarrodek commented Feb 8, 2022

I believe I have found the root cause of the issue presented in this issue report. I patched the application with workarounds and soon I'll publish an update (within hours).

I reported a detailed bug report in Electron (electron/electron#32774).

In short, the following happened:

  • There was an issue with the fs-extra library (or rather its dependency graceful-fs) which was throwing an error when the application was trying to initialize theme files. This caused the issue with the application that you have reported in this issue report
  • While working on the workaround I discovered a deeper problem with Electron that was prohibiting accessing packaged application files

The workaround is to use my own implementation similar to fs-extra to process the theme files. So far it looks like I was able to successfully perform a fresh installation of the application.

This ticket will be closed automatically soon but please, re-open if after the next release the issue persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants