Skip to content

Add to ui5 model #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 28, 2025
Merged

Add to ui5 model #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8887954
Add datepicker sap/m/DatePicker to ui5 model yaml
knewbury01 Nov 10, 2025
73c10bd
Add improved test cases to tests that cover ui5 sap.m.X type widgets
knewbury01 Nov 21, 2025
0d2cbe8
Merge branch 'main' into knewbury01/update-ui5-models
knewbury01 Nov 26, 2025
0737bfd
Update test expected file
knewbury01 Nov 26, 2025
4d886fa
Merge branch 'knewbury01/update-ui5-models' of https://github.com/adv…
knewbury01 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions javascript/frameworks/ui5/ext/ui5.model.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ extensions:
- ["UI5InputControl", "sap/m/MaskEnabler", ""]
- ["UI5InputControl", "sap/m/MaskInput", ""]
- ["UI5InputControl", "sap/m/TextArea", ""]
- ["UI5InputControl", "sap/m/DatePicker", ""]
- ["UI5InputControl", "sap/m/ComboBoxBase", ""]
- ["UI5InputControl", "sap/m/MultiInput", ""]
- ["UI5InputControl", "sap/ui/webc/main/MultiInput", ""]
Expand Down
10 changes: 10 additions & 0 deletions javascript/frameworks/ui5/test/models/source/UI5ViewSourceTest.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,11 @@
| source1.xml:5:5:7:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:8:5:10:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:11:5:13:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:14:5:16:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:17:5:19:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:20:5:22:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:23:5:25:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:26:5:28:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:29:5:31:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:32:5:34:28 | value={/input} | The binding path `/input` is a user input source. |
| source1.xml:35:5:37:28 | value={/input} | The binding path `/input` is a user input source. |
30 changes: 30 additions & 0 deletions javascript/frameworks/ui5/test/models/source/source1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,34 @@
<Input placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.Input.value -->
<ComboBoxTextField placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.ComboBoxTextField.value -->
<MaskEnabler placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.MaskEnabler.value -->
<MaskInput placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.MaskInput.value -->
<TextArea placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.TextArea.value -->
<DatePicker placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.DatePicker.value -->
<ComboBoxBase placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.ComboBoxBase.value -->
<SearchField placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.SearchField.value -->
<MultiInput placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.MultiInput.value -->
<FeedInput placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.FeedInput.value -->
<InputBase placeholder="Enter Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.InputBase.value -->
</mvc:View>
58 changes: 49 additions & 9 deletions javascript/frameworks/ui5/test/queries/UI5Xss/xss-html-control/UI5Xss.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,53 @@
nodes
| webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:5:5:7:28 | value={/input} |
| webapp/view/app.view.xml:8:5:8:36 | content={/input} |
| webapp/view/app.view.xml:5:6:7:28 | value={/input} |
| webapp/view/app.view.xml:8:5:9:28 | value={/input} |
| webapp/view/app.view.xml:10:5:11:28 | value={/input} |
| webapp/view/app.view.xml:12:5:13:28 | value={/input} |
| webapp/view/app.view.xml:14:5:15:28 | value={/input} |
| webapp/view/app.view.xml:16:5:17:28 | value={/input} |
| webapp/view/app.view.xml:18:5:19:28 | value={/input} |
| webapp/view/app.view.xml:20:5:21:28 | value={/input} |
| webapp/view/app.view.xml:22:5:23:28 | value={/input} |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} |
edges
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:5:5:7:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:8:5:8:36 | content={/input} |
| webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) | webapp/view/app.view.xml:8:5:8:36 | content={/input} |
| webapp/view/app.view.xml:5:5:7:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:5:5:7:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:8:5:8:36 | content={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:5:6:7:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:8:5:9:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:10:5:11:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:12:5:13:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:14:5:15:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:16:5:17:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:18:5:19:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:20:5:21:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:22:5:23:28 | value={/input} |
| webapp/controller/app.controller.js:9:17:9:27 | input: null | webapp/view/app.view.xml:24:5:24:36 | content={/input} |
| webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) | webapp/view/app.view.xml:24:5:24:36 | content={/input} |
| webapp/view/app.view.xml:5:6:7:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:5:6:7:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:8:5:9:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:8:5:9:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:10:5:11:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:10:5:11:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:12:5:13:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:12:5:13:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:14:5:15:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:14:5:15:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:16:5:17:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:16:5:17:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:18:5:19:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:18:5:19:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:20:5:21:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:20:5:21:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:22:5:23:28 | value={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
| webapp/view/app.view.xml:22:5:23:28 | value={/input} | webapp/controller/app.controller.js:11:26:11:45 | new JSONModel(oData) |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/controller/app.controller.js:9:17:9:27 | input: null |
#select
| webapp/view/app.view.xml:8:5:8:36 | content={/input} | webapp/view/app.view.xml:5:5:7:28 | value={/input} | webapp/view/app.view.xml:8:5:8:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:5:5:7:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:5:6:7:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:5:6:7:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:8:5:9:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:8:5:9:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:10:5:11:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:10:5:11:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:12:5:13:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:12:5:13:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:14:5:15:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:14:5:15:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:16:5:17:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:16:5:17:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:18:5:19:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:18:5:19:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:20:5:21:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:20:5:21:28 | value={/input} | user-provided value |
| webapp/view/app.view.xml:24:5:24:36 | content={/input} | webapp/view/app.view.xml:22:5:23:28 | value={/input} | webapp/view/app.view.xml:24:5:24:36 | content={/input} | XSS vulnerability due to $@. | webapp/view/app.view.xml:22:5:23:28 | value={/input} | user-provided value |
18 changes: 17 additions & 1 deletion javascript/frameworks/ui5/test/queries/UI5Xss/xss-html-control/webapp/view/app.view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,24 @@
xmlns="sap.m"
xmlns:core="sap.ui.core"
xmlns:mvc="sap.ui.core.mvc">
<Input placeholder="Enter Payload"
<Input placeholder="Enter Input Payload"
description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;"
value="{/input}" /> <!--User input source sap.m.Input.value -->
<ComboBoxTextField placeholder="Enter ComboBoxTextField Payload"
value="{/input}" /> <!--User input source sap.m.ComboBoxTextField.value -->
<DatePicker placeholder="Enter DatePicker Payload"
value="{/input}" /> <!--User input source sap.m.DatePicker.value -->
<TextArea placeholder="Enter TextArea Payload"
value="{/input}" /> <!--User input source sap.m.TextArea.value -->
<ComboBoxBase placeholder="Enter ComboBoxBase Payload"
value="{/input}" /> <!--User input source sap.m.ComboBoxBase.value -->
<SearchField placeholder="Enter SearchField Payload"
value="{/input}" /> <!--User input source sap.m.SearchField.value -->
<MultiInput placeholder="Enter MultiInput Payload"
value="{/input}" /> <!--User input source sap.m.MultiInput.value -->
<FeedInput placeholder="Enter FeedInput Payload"
value="{/input}" /> <!--User input source sap.m.FeedInput.value -->
<InputBase placeholder="Enter InputBase Payload"
value="{/input}" /> <!--User input source sap.m.InputBase.value -->
<core:HTML content="{/input}"/> <!--XSS sink sap.ui.core.HTML.content -->
Copy link

Copilot AI Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of new input controls in this file causes the <core:HTML> element to move from line 8 (where it was previously) to line 24. However, the expected test results file UI5Xss.expected in this test directory has not been updated and still references line 8 for the HTML content binding. This will cause the test to fail. The expected file needs to be regenerated or manually updated to reflect the new line numbers (line 24 instead of line 8 for content={/input}).

Copilot uses AI. Check for mistakes.
</mvc:View>
Loading