-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectral Positional Encoding #45
Comments
Wow! Great that you've noticed that :) We experimented with positional encoding in spectral domain just a little bit. It did not help for the inpainting on our benchmarks - but might work in other cases. But we did not explore that feature thoroughly enough to say something for sure. I'll be happy to hear back if this feature helps :) |
Interesting, I would expect positional encoding (possibly a different encoding than a simple linear mesh) would have helped. So, this suggests a few possible outcomes (1x1 filter/conv here will always refer to the conv in the frequency domain inside the Spectral Transform block):
|
Hi @BrianPugh, Have you done any further research on that? |
i have not had a chance/the resources to perform experiments with these changes. |
Great idea!I agree with you. Maybe I can do some experiments. |
Hi, have you done an experiment? What was the result? |
I see in your
FourierUnit
you added an optionalspectral_pos_encoding
argument. Have you experimented at all with this? Has it improved/reduced performance?The text was updated successfully, but these errors were encountered: