Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass buttonRadius prop into Google Pay Button #2669

Closed
fr-richard opened this issue May 1, 2024 · 2 comments
Closed

Pass buttonRadius prop into Google Pay Button #2669

fr-richard opened this issue May 1, 2024 · 2 comments
Labels
Enhancement New feature or request Progress: on hold

Comments

@fr-richard
Copy link

fr-richard commented May 1, 2024

Problem:
We cannot customize Google Pay button radius.

Is your feature request related to a problem? Please describe.
In the GooglePayButton component, it should support buttonRadius prop, however, Adyen's Google Pay button doesn't pass buttonRadius prop

GooglePayButton documentation:
https://developers.google.com/pay/api/web/reference/request-objects#ButtonOptions

Adyen Google Pay button documentation:
https://docs.adyen.com/payment-methods/google-pay/web-component/

Proposed solution:
Adyen should pass borderRadius prop here
https://github.com/Adyen/adyen-web/blob/main/packages/lib/src/components/GooglePay/GooglePay.tsx#L135-L143

@fr-richard fr-richard added the Enhancement New feature or request label May 1, 2024
@ribeiroguilherme
Copy link
Contributor

ribeiroguilherme commented Jun 11, 2024

Hey @fr-richard ,

Thanks for flagging this. It is a new property that got added recently in the GooglePay SDK: https://developers.google.com/pay/api/web/support/release-notes#mar-24

We will add support for it and I will let you know once we release that.

@ribeiroguilherme
Copy link
Contributor

Hey @fr-richard - we added this feature in the most recent release. Thanks for flagging it. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Progress: on hold
Projects
None yet
Development

No branches or pull requests

2 participants