New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning in Rails 5 #143

Closed
yurijmi opened this Issue Jul 2, 2016 · 11 comments

Comments

Projects
None yet
8 participants
@yurijmi

yurijmi commented Jul 2, 2016

In this file:

DEPRECATION WARNING: alias_method_chain is deprecated.
Please, use Module#prepend instead. From module, you can access the original method using super.
@adzap

This comment has been minimized.

Owner

adzap commented Jul 3, 2016

Thanks. Obviously haven't updated for Rails 5. Will likely bump gem to v5 and remove old Rails stuff. A clean break, including this change.

@dgilperez

This comment has been minimized.

dgilperez commented Aug 18, 2016

Hi! Any news? Is validates_timeliness Rails5 compatible?

@rposborne

This comment has been minimized.

rposborne commented Mar 3, 2017

@adzap Anything we can do to help?

@hunzinker

This comment has been minimized.

hunzinker commented Apr 19, 2017

Hi! Any update on this issue?

Thanks!

@bjensen

This comment has been minimized.

bjensen commented Mar 8, 2018

still not rails 5 compatible?

@svoop

This comment has been minimized.

svoop commented Mar 9, 2018

@adzap

Given this issue and the last commit dating back to May 2017, I have to ask the question: Are you still maintaining these gems? It's totally okay if you have lost interest, happens to all of us sometimes, but I (and others I presume) have to decide where to go from here and whether to stick to "timeliness" and friends.

Also, there are 129 forks. If you ask the community, someone might step forward and continue your work by adopting the "timeliness" gems.

In any case, thanks a bunch for your work on these gems!

@adzap

This comment has been minimized.

Owner

adzap commented Mar 9, 2018

Hi all. I haven't given up, I just haven't gotten around to upgrading my own apps to Rails 5 which has always been to the trigger. It all comes down to my availability which is has been terribly low I'm afraid.

So my Rails 5 upgrade plans are within the 2 months. I have been reluctant to hand off this project off because I am still actively using and interested in maintaining and I really wanted to clean it up a lot and shed the cruft from supporting old AR versions.

Appreciate the interest and the frustration.

Also currently there are no compelling PRs to do the upgrade. So it has not been a simple choice of merging a PR from the community which would accelerate all this. So if someone is interested in pulling together a PR of changes with specs we can review and discuss that would be excellent.

@svoop

This comment has been minimized.

svoop commented Mar 9, 2018

@adzap Great to know you're still on board! No worries though, I've been an "upgrade slut" myself. I'll have to check to what extent we're using timeliness and if we keep it, I'll surely PR the fixes our app needs to keep going.

@AquisTech

This comment has been minimized.

Contributor

AquisTech commented May 14, 2018

@adzap I have faced this now as an exception as I am working on Rails 5.2.0.
I saw some recent commits of you regarding Rails 5 upgrades.
Please let me know if you are working on this particular alias_method_change issue.
Else I can fix it and send you a PR. Thoughts?

@AquisTech

This comment has been minimized.

Contributor

AquisTech commented May 14, 2018

@adzap I have fixed this issue and raised PR #167 please review and merge it.

@adzap

This comment has been minimized.

Owner

adzap commented May 15, 2018

This specific issue is resolved after PR #167 but there is still more work to fix other issues before a Rails 5 release.

@adzap adzap closed this May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment