Skip to content

Range with excluded end passed to :between option should be split into :on_or_after and :before options #98

Merged
merged 1 commit into from Apr 30, 2013

2 participants

@907th
907th commented Apr 23, 2013

If you use range with excluded end in :between option, e.g.

validates_date :field, between: date1...date2

it should be treated as

validates_date :field, on_or_after: date1, before: date2

I also added test for that issue.

@adzap
Owner
adzap commented Apr 26, 2013

This sounds very reasonable and logical. Could you also add some comments to the README?

@907th
907th commented Apr 27, 2013

I added examples to README.

@adzap
Owner
adzap commented Apr 28, 2013

There's a comment in the README under the error messages section about the :between error messages. We should have a something there also since the error message keys are different in this case. Can you please add that also? Thanks

@907th
907th commented Apr 30, 2013

Done. Please, check it.

@adzap adzap merged commit 3d79869 into adzap:master Apr 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.