Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width is not being set to Size I provided via props for resizable spaces #29

Closed
thekapadia opened this issue Oct 9, 2019 · 5 comments
Labels
bug

Comments

@thekapadia
Copy link

@thekapadia thekapadia commented Oct 9, 2019

@aeagle I'm facing this problem.

Step 1: I initially have,
<Left resizable={true} size={200}> Left Section </Left>

Step 2: Now on click of a button, I'm manually toggling the size prop between 10 and 200. All works well.

Step 3: Now I resize this space by dragging it, thus, let's say, increasing the size by 20.

Step 4: I repeat Step 2. This is where the problem occurs. The calculated width becomes calc(30px) and calc(220px). Somehow the resized delta is being added to the size I'm providing.

@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Oct 9, 2019

@thekapadia Looks like a problem with the resize delta not being reset in state for a space when the size prop is changed. I'll have a proper look and hopefully have a fix shortly.

@thekapadia

This comment has been minimized.

Copy link
Author

@thekapadia thekapadia commented Oct 16, 2019

Hi @aeagle - just checking in to see if there's any update on this issue.

@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Oct 16, 2019

@thekapadia - I'm nearly there with a fix: bdfe576

However there seems to be some strange behavior when testing with spaces that are stacked. Once I get this resolved I will release. Hopefully not much longer.

@aeagle aeagle added the bug label Oct 17, 2019
@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Oct 17, 2019

@thekapadia I've published a fix for this in version 0.1.17. Let me know if this resolves your issue.

@Slapbox

This comment has been minimized.

Copy link

@Slapbox Slapbox commented Oct 18, 2019

@aeagle I'm realizing my issue #36 is an exact duplicate of this one.

I tried 0.1.17 yesterday thinking also that one of your commits looked likely to resolve the issue before realizing what was going on and updating my issue.

@aeagle aeagle closed this Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.