Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing zIndex dynamically has no effect #42

Open
thekapadia opened this issue Oct 22, 2019 · 9 comments
Labels
bug

Comments

@thekapadia
Copy link

@thekapadia thekapadia commented Oct 22, 2019

@aeagle When I change the zIndex dynamically, it has no effect while trying to achieve layering without wrapping into the Layer component.

Demo

@aeagle aeagle added the bug label Oct 22, 2019
@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Oct 22, 2019

@thekapadia Thanks for the examples. I'll look into this shortly. I can see the space has registered a move into a different layer, however, the spaces already in the target area have not been updated to take into account the new space.

@thekapadia

This comment has been minimized.

Copy link
Author

@thekapadia thekapadia commented Oct 23, 2019

@aeagle And somewhere even the calc() is going wrong. Spaces are being misplaced.

Here's what I'm trying to achieve in my project using React Spaces.
https://codesandbox.io/s/icy-dust-ouf6l

I'm trying to get pinnable panels, which I can Open or Close (no change in zIndex, only size changes), and Pin or Unpin (change in zIndex and size, both).

@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Oct 23, 2019

@thekapadia Thanks for the sandbox. I'll have a play later to try to resolve.

@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Oct 23, 2019

@thekapadia I've released version 0.1.19 which should resolve this.

Here is an example based on your original sandbox - https://codesandbox.io/s/patient-water-fpe2c?fontsize=14

@thekapadia

This comment has been minimized.

Copy link
Author

@thekapadia thekapadia commented Oct 24, 2019

Thanks @aeagle for the fix and quick turnaround. Really appreciate.

One more thing, I just noticed another issue.

Check https://codesandbox.io/s/elated-bose-obcq3 (forked from your example above).

I added resizable={true} to the first Left space.

Now do the following.

  1. Click Open in the left space.
  2. Stretch/expand the left space by drag-and-resize.
  3. Click Pin in the left space.

Observe the blank white space being generated.

@thekapadia

This comment has been minimized.

Copy link
Author

@thekapadia thekapadia commented Oct 29, 2019

Hi @aeagle - just passing by to see if there's any update on this resizable issue. Thanks!

@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Oct 30, 2019

Hi @thekapadia. I'm in the middle of working on a new release so I'm hoping to get this fixed and a few other issues in that. Hopefully not too long now.

@thekapadia

This comment has been minimized.

Copy link
Author

@thekapadia thekapadia commented Nov 11, 2019

Hi @thekapadia. I'm in the middle of working on a new release so I'm hoping to get this fixed and a few other issues in that. Hopefully not too long now.

Hi @aeagle - just curious to know a tentative release date.

@aeagle

This comment has been minimized.

Copy link
Owner

@aeagle aeagle commented Nov 12, 2019

Hi @thekapadia. I'm struggling with some state issues at the moment. Rest assured once I sort I'll release. I'm planning to look at this and the other issues this weekend so hopefully then. Thanks for the patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.