New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Hostmaster container upgradable. #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new environment variable AEGIR_HOSTMASTER_ROOT to make the path to hostmaster fixed. - Check for an active hostmaster as soon as database is available in docker-entrypoint.sh. If @hostmaster responds, run 'drush updb -y' immediately, then provision-verify! - If hostmaster does not respond, run the drush @hostmaster-install command - Set 'root' option explicity to $AEGIR_HOSTMASTER_ROOT in 'drush hostmaster-install' command. - Remove the confusing AEGIR_VERSION variable, as it is only used by drush_hostmaster_install() function to determine what path to install hostmaster to. Instead of that, we are fixing the path since we want to be able to replace the containers without having to dynamically alter anything. First big step towards upgradable Aegir containers!
…images to install the right version.
…of PROVISION_VERSION
…latform exists, if so, run hostmaster-migrate on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR changes the file layout of the home folder so that /var/aegir/hostmaster is the path.
This is so subsequent container versions can replace those files.
I've altered the entrypoint.sh script to check for an active hostmaster, and if it's there, immediately run drush updb on it. This will allow easy container based upgrades to Aegir.
It seems to work pretty well!
See this commit for a detailed description of what changed: 3495fdc