Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2926905: Disable caching on CiviCRM paths with i18n prefixes. #16

Closed
wants to merge 2 commits into from

Conversation

mlutfy
Copy link

@mlutfy mlutfy commented Nov 28, 2017

@omega8cc
Copy link
Contributor

omega8cc commented Jan 12, 2018

Honestly, I'm not in favor of replacing the much faster location ^~ with simple location ~* wildcard. It may seem not very relevant until you see the rewrites flood Nginx is doing if you are using wildcard instead of "stop here" matching location ^~

We are trying to use location ^~ everywhere we can, for obvious performance reasons, and CiviCRM generates a ton of such requests, so I would rather propose to add i18n location below current location, so it will work only for i18n prefixes. Then you don't need the ? and location ~* ^/\w\w/civicrm { is enough, as proposed on https://www.drupal.org/project/provision/issues/2926905

@omega8cc
Copy link
Contributor

omega8cc commented Jan 18, 2018

We will propose a patch, but next week, if you allow.

@omega8cc
Copy link
Contributor

omega8cc commented Jan 19, 2018

@mlutfy
Copy link
Author

mlutfy commented Jan 25, 2018

Closing this PR, since a patch was merged on d.o.

@mlutfy mlutfy closed this Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants