feat: add a button to fetch post titles

[sharunkumar]

should resolve #817

currently uses proxying to fetch in case of PWA, due to CORS issues when doing it directly

[aeharding]

Thanks for the PR! Why not use getSiteMetadata like lemmy-ui, though?

[sharunkumar]

Thanks for the PR! Why not use getSiteMetadata like lemmy-ui, though?

was not aware of this, will check it out 👀

update: implemented it but the title does seem different from the earlier implementation though:

[aeharding]

@sharunkumar I moved around the field a bit. Now, it displays "autofill" next to the title box after you've entered a URL, but not if you've already typed in the title field.

Let me know what you think.

[sharunkumar]

@sharunkumar I moved around the field a bit. Now, it displays "autofill" next to the title box after you've entered a URL, but not if you've already typed in the title field.

Let me know what you think.

looks perfect 👍

[fer0n]

Thanks for working on this :)

Regarding the implementation: there's an argument to be made that it should auto fill whenever the title is empty and a URL is entered. The button to trigger the auto fill could still be there, but wouldn't have to (makes the UI a bit cleaner without, but being deliberate has also advantages).

I'd personally go with auto fill an empty title (show a spinner in the title field while loading) and otherwise do nothing, but that's up to you.

[sharunkumar]

it should auto fill whenever the title is empty and a URL is entered

this is there in the latest commit made by @aeharding

[fer0n]

Ah, nice. Apologies for the comment then.

[aeharding]

Ah, nice. Apologies for the comment then.

It doesn't automatically fetch the post title - you still need to press the button.

I thought about that, however in some cases the request took an abnormal amount of time, so I opted not to. Once we have this in the wild we can totally revisit this though, it would be a very small change!

[aeharding]

Thanks for this!