Skip to content

Commit

Permalink
Merge pull request #15 from GUI/master
Browse files Browse the repository at this point in the history
fix variable scope to fix the tag removal button
  • Loading branch information
aehlke committed Aug 9, 2011
2 parents 47c4a0a + f816b26 commit f868ea9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion js/tag-it.js
Expand Up @@ -293,7 +293,7 @@
},

createTag: function(value, additionalClass) {
that = this;
var that = this;
// Automatically trims the value of leading and trailing whitespace.
value = $.trim(value);

Expand Down

2 comments on commit f868ea9

@deftstar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same fix should be applied to
removeTag: function(tag, animate) {
var that = this;
and change all the this to that,

i had problem when i was using multiple tag-its in on page, when i remove the tag at the first try ontagremoved event dont work the way its suppose to.

so i added this same fix to it and all is good :D

@aehlke
Copy link
Owner Author

@aehlke aehlke commented on f868ea9 Aug 10, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey muhamin
please send me a pull request on that fix, and I'll gladly merge it. thanks!

Please sign in to comment.