valid xhtml #24

Closed
berwinter opened this Issue Aug 26, 2011 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

berwinter commented Aug 26, 2011

please add a close tag to the input fields (e. g. ) - otherwise it's not valid xhtml

Owner

aehlke commented Aug 26, 2011

Hi,
I wrote this to conform to HTML5, not XHTML. If you show me that self closing tags are valid in HTML5 (I'm guessing they are, I'm just not positive), then I'd be glad to change this or accept a patch from you.
Thanks!
Alex

Sent from my iPhone

On Aug 26, 2011, at 4:11 AM, berwinterreply@reply.github.com wrote:

please add a close tag to the input fields (e. g. ) - otherwise it's not valid xhtml

Reply to this email directly or view it on GitHub:
#24

Contributor

berwinter commented Aug 26, 2011

is also valid HTML5 but has another meaning than in XHTML. In XHTML means but in HTML5 it means only , so it is valid for both. Another valid option would be to write , but I think jQuery UI uses also the variant.
Sry I'm new to github and don't know how to create/add a patch. But if you want to fix it, it have to be changed only in line 99, 151 and 334.

thx
bertram

Owner

aehlke commented Aug 26, 2011

Thanks for the info. It seems fine then. I'm away from a computer until next week though. So if you want a patch soonerthan later, please google for a github tutorial - its pretty easy. You just need to fork my project, edit the file (whichyou can do inside the browser) and then submit a Pull Request on my project after you commit your changes. I can accept a pull request from my iPhone then.
Thanks
Alex

Sent from my iPhone

On Aug 26, 2011, at 4:43 AM, berwinterreply@reply.github.com wrote:

is also valid HTML5 but has another meaning than in XHTML. In XHTML means but in HTML5 it means only , so it is valid for both. Another valid option would be to write , but I think jQuery UI uses also the variant.
Sry I'm new to github and don't know how to create/add a patch. But if you want to fix it, it have to be changed only in line 99, 151 and 334.

thx
bertram

Reply to this email directly or view it on GitHub:
#24 (comment)

berwinter closed this Aug 26, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment