Clarify tag addition/removal events #5

Closed
aehlke opened this Issue Jun 23, 2011 · 3 comments

Comments

Projects
None yet
2 participants
Owner

aehlke commented Jun 23, 2011

  • Deprecate the onTagRemoved and onTagAdded events.
  • Add before/after events for each instead. (decide on some idiomatic name for it)
Owner

aehlke commented Jun 23, 2011

Previous discussion: #4

This one is open to comments before we proceed... thanks.

Not really a big deal for me. If you want to just fix the onTagAdded so it is consistent with onTagRemoved, that would probably be best. That way, if you want to add support for canceling the event later, you can do that.

Owner

aehlke commented Nov 23, 2012

Fixed with 28e6161 thanks! Please check the updates to the docs for relevant details.

@aehlke aehlke closed this Nov 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment