Skip to content

Call order of beforeTagAdded, specifically when using singleField configuration #125

Closed
wants to merge 1 commit into from

2 participants

@BBonifield

Issue:
When using the singleField configuration option, the tag would be appended to the hidden field before the beforeTagAdded callback was actually ran. The net result was that the hidden field would contain invalid tag data.

Fix:
The callback is now being ran before the tag DOM is created and before the singleField is updated.

@BBonifield BBonifield When using the singleField configuration option, the tag would be add…
…ed to the hidden field even if the beforeTagAdded callback returned false.
34bb675
@aehlke
Owner
aehlke commented Nov 27, 2012

Thanks, good catch! It needed a little refactoring since I'm passing the tag to the callback - fixed it in d5fe008

@aehlke aehlke closed this Nov 27, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.