Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with resolution of git.properties by giving it a unique name #1505

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

johngrimes
Copy link
Member

Resolves #1187.

@johngrimes johngrimes added the bug Something isn't working label Jun 28, 2023
@johngrimes johngrimes self-assigned this Jun 28, 2023
@johngrimes johngrimes added this to the v6.2.3 milestone Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.03 ⚠️

Comparison is base (bd557ef) 85.51% compared to head (e8642c1) 85.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1505      +/-   ##
============================================
- Coverage     85.51%   85.49%   -0.03%     
  Complexity      139      139              
============================================
  Files           339      339              
  Lines          7806     7809       +3     
  Branches        519      519              
============================================
+ Hits           6675     6676       +1     
- Misses          841      843       +2     
  Partials        290      290              
Impacted Files Coverage Δ
...c/main/java/au/csiro/pathling/PathlingVersion.java 68.18% <ø> (ø)
lib/python/pathling/context.py 80.64% <50.00%> (-1.03%) ⬇️
...ava/au/csiro/pathling/library/PathlingContext.java 93.33% <50.00%> (-1.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@johngrimes johngrimes changed the base branch from main to release/6.2.3 June 28, 2023 06:54
Copy link
Collaborator

@piotrszul piotrszul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@johngrimes johngrimes merged commit d97a798 into release/6.2.3 Jun 30, 2023
19 checks passed
@johngrimes johngrimes deleted the issue/1187 branch June 30, 2023 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong version advertised by library terminology client
2 participants