Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detection of deb package manager is incorrect #320

Closed
guillemj opened this issue Feb 23, 2018 · 2 comments · Fixed by #535
Closed

Detection of deb package manager is incorrect #320

guillemj opened this issue Feb 23, 2018 · 2 comments · Fixed by #535
Labels
approved bug

Comments

@guillemj
Copy link
Contributor

The detection in DetectPackageManager for the deb package manager seems incorrect. There's no such command as deb, the command should be dpkg. :)
@aelsabbahy
Copy link
Member

Good catch, guess the DetectDistro was working well, so no one noticed :)

Feel free to submit a pull request, otherwise I'll fix it with the next release.

@aelsabbahy aelsabbahy added the bug label Feb 23, 2018
@catdevman
Copy link

@aelsabbahy I am new to writing Go but I would like to fix this. Anything special I need to know before I get started. Looks like it would just be changing "deb" to "dpkg". Seems like it might need a regression test but wasn't sure if you had that sort of suite. Just looking for an easy place to get my toes wet.

@pedroMMM pedroMMM mentioned this issue Jan 3, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#320] Correct Debian package discovery pedroMMM/goss
3 participants
@guillemj @aelsabbahy @catdevman