Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for gofmt compliance as part of CI #445

Closed
aelsabbahy opened this issue May 12, 2019 · 2 comments
Closed

Check for gofmt compliance as part of CI #445

aelsabbahy opened this issue May 12, 2019 · 2 comments

Comments

@aelsabbahy
Copy link
Owner

@aelsabbahy aelsabbahy commented May 12, 2019

No description provided.

@aelsabbahy aelsabbahy added the approved label Dec 12, 2019
pedroMMM added a commit to pedroMMM/goss that referenced this issue Dec 14, 2019
@pedroMMM pedroMMM mentioned this issue Dec 14, 2019
1 of 1 task complete
aelsabbahy added a commit that referenced this issue Dec 18, 2019
* [#445] Add gofmt validation to CI

* Show files that weren't compliant to gofmt

Co-Authored-By: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com>

* Limit gofmt to actual code base by excluding vendor and test files
@pedroMMM

This comment has been minimized.

Copy link
Contributor

@pedroMMM pedroMMM commented Dec 18, 2019

@aelsabbahy It can be closed now.

@aelsabbahy

This comment has been minimized.

Copy link
Owner Author

@aelsabbahy aelsabbahy commented Dec 18, 2019

Thanks for catching this and thanks for all your contributions. A release is being cut as we speak with some of your changes.

By the way in the future you can add fixes #tickernumber and it'll automatically close it: https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords

I'll update the PR template to include a section for this.

@aelsabbahy aelsabbahy closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.