New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob pattern support to gossfile #223

Merged
merged 2 commits into from Apr 23, 2017

Conversation

Projects
None yet
2 participants
@AlexandreCarlton
Contributor

AlexandreCarlton commented Apr 9, 2017

This will ease the addition of tests to an existing goss test suite.

All that is necessary is to drop in a file matching the existing pattern. As an example:

gossfile:
  /etc/goss.d/*.yaml: {}

Unfortunately, I wasn't sure where to place this in the existing integration tests; where might a good place for such a test be?

References #222

Add glob pattern support to gossfile
This will ease the addition of tests to an existing goss test suite. All
that is necessary is to drop in a file matching the existing pattern.

References #222
@aelsabbahy

This comment has been minimized.

Show comment
Hide comment
@aelsabbahy

aelsabbahy Apr 9, 2017

Owner

This looks great!

For integratiin tesrs maybe change these imports: https://github.com/aelsabbahy/goss/blob/master/integration-tests/goss/wheezy/goss.yaml#L26

To:

gossfile:
    ../goss-s*.yaml: {}

in all applicable server types.

Owner

aelsabbahy commented Apr 9, 2017

This looks great!

For integratiin tesrs maybe change these imports: https://github.com/aelsabbahy/goss/blob/master/integration-tests/goss/wheezy/goss.yaml#L26

To:

gossfile:
    ../goss-s*.yaml: {}

in all applicable server types.

Convert tests to use glob patterns for gossfiles
This is done with the exception of 'arch', which only includes
'goss-shared.yaml'.
@AlexandreCarlton

This comment has been minimized.

Show comment
Hide comment
@AlexandreCarlton

AlexandreCarlton Apr 10, 2017

Contributor

Done.

Thank you for creating goss, it's an incredibly useful tool. :)

Contributor

AlexandreCarlton commented Apr 10, 2017

Done.

Thank you for creating goss, it's an incredibly useful tool. :)

@aelsabbahy aelsabbahy merged commit 12d355a into aelsabbahy:master Apr 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment