New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor resource configuration validation #233

Merged
merged 4 commits into from Jul 1, 2017

Conversation

Projects
None yet
2 participants
@OmarDarwish
Contributor

OmarDarwish commented May 9, 2017

This refactors the way that resource configurations are checked. The first time I encountered this code, I had a little difficulty understanding the intention and what was happening. I hope these changes make it a little bit clearer.

This pull request is a precursor to #226, which uses the utility functions introduced in this PR.

@aelsabbahy

This comment has been minimized.

Show comment
Hide comment
@aelsabbahy

aelsabbahy May 10, 2017

Owner

Looks good. However, I don't see ValidateSection being used in either this PR or #226.

Owner

aelsabbahy commented May 10, 2017

Looks good. However, I don't see ValidateSection being used in either this PR or #226.

@OmarDarwish

This comment has been minimized.

Show comment
Hide comment
@OmarDarwish

OmarDarwish May 10, 2017

Contributor

Ah you're right @aelsabbahy! I was using it for my AWS resources. I'll remove it now. Good catch!

Contributor

OmarDarwish commented May 10, 2017

Ah you're right @aelsabbahy! I was using it for my AWS resources. I'll remove it now. Good catch!

@aelsabbahy aelsabbahy merged commit 650c25d into aelsabbahy:master Jul 1, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment