New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic auth for http resource #327

Merged
merged 7 commits into from May 20, 2018

Conversation

Projects
None yet
2 participants
@Ntr0
Contributor

Ntr0 commented Mar 7, 2018

This patch will enable optional basic auth for the http resource. Therefore
it introduces two new parameters: username and password. If any of both is
set, the request will be performed using HTTP Basic Auth.

And, thanks for goss. Its awesome.

Add basic auth for http resource
This patch will enable optional basic auth for the http resource. Therefore
it introduces two new parameters: username and password. If any of both is
set, the request will be performed using HTTP Basic Auth.
@aelsabbahy

This comment has been minimized.

Owner

aelsabbahy commented Mar 26, 2018

Sorry for the delay in reviewing this.

Can you add a test for this. Thinking using something like: https://httpbin.org

@Ntr0

This comment has been minimized.

Contributor

Ntr0 commented Mar 29, 2018

@aelsabbahy Can you give me a hint why the ci build fails? It seems that this check should pass: Addr: tcp://localhost:80: reachable: true But I cannot see how I this is related to my change?

@aelsabbahy

This comment has been minimized.

Owner

aelsabbahy commented Mar 29, 2018

The assertion output in the test.sh need to be updated to reflect the new test count.
https://github.com/aelsabbahy/goss/blob/master/integration-tests/test.sh#L46-L49

Ntr0 added some commits Apr 11, 2018

Fix test count
Got wrong how tests are counted.
@Ntr0

This comment has been minimized.

Contributor

Ntr0 commented Apr 17, 2018

Hi @aelsabbahy, would you please rereview my PR?

@aelsabbahy aelsabbahy merged commit cc29f25 into aelsabbahy:master May 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aelsabbahy

This comment has been minimized.

Owner

aelsabbahy commented May 20, 2018

This is awesome, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment