Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of Source IP for Addr Test #344

Merged
merged 6 commits into from Dec 18, 2019

Conversation

@CBeerta
Copy link
Contributor

CBeerta commented Apr 12, 2018

This Change allows the Source IP with which the Addr test is run to be
set.

Copy link
Owner

aelsabbahy left a comment

Love the change, once the tests are updated/passing in CI I'll merge this.

Title string `json:"title,omitempty" yaml:"title,omitempty"`
Meta meta `json:"meta,omitempty" yaml:"meta,omitempty"`
Address string `json:"-" yaml:"-"`
LocalAddress string `json:"localaddress" yaml:"localaddress"`

This comment has been minimized.

Copy link
@aelsabbahy

aelsabbahy May 20, 2018

Owner

Should have an "omitempty" for this.

@CBeerta CBeerta force-pushed the CBeerta:addr-set-source-ip branch from 4115d93 to 2f8fbf0 May 22, 2018
This Change allows the Source IP with which the Addr test is run to be
set.
@CBeerta CBeerta force-pushed the CBeerta:addr-set-source-ip branch from 2f8fbf0 to ac37b60 May 22, 2018
@CBeerta

This comment has been minimized.

Copy link
Contributor Author

CBeerta commented May 22, 2018

I had that fix locally already, never committed. And rebased to the master version.

Hope this is ok now, i actually really have no clue about programming go :P

aelsabbahy added 5 commits Dec 18, 2019
@aelsabbahy aelsabbahy merged commit e5d28f3 into aelsabbahy:master Dec 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.