Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid CLI flags #421

Merged

Conversation

Projects
None yet
2 participants
@mkobit
Copy link
Contributor

commented Jan 31, 2019

Previously, the flags were not handled so the application would
Looking at the documentation for https://github.com/urfave/cli , the error is propogated up through the app.Run call.
Now, the error is checked before fatally logging it.

closes #420

Handle invalid CLI flags
Previously, the flags were not handled so the application would
Looking at the documentation for https://github.com/urfave/cli , the error is propogated up through the `app.Run` call.
Now, the error is checked before fatally logging it.

closes #420
@aelsabbahy

This comment has been minimized.

Copy link
Owner

commented May 12, 2019

Nice catch, thanks!

@aelsabbahy aelsabbahy merged commit 5b23ea2 into aelsabbahy:master May 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.