Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from dep to go modules. #437

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@stefan-improbable
Copy link
Contributor

commented Apr 10, 2019

Go modules seem to be the future of managing golang dependencies. This PR also simplifies .travis.yml and Makefile a bit.

Travis tests are failing due to dnstest.io being down, but apart from that, build and unit tests work.

@aelsabbahy if you want, I can send you a PR to disable those dnstest.io tests temporarily.

stefan-improbable added some commits Apr 10, 2019

@aelsabbahy

This comment has been minimized.

Copy link
Owner

commented Apr 23, 2019

Merged #440 to disable the test. Rebase when you get a chance.

This change is great by the way, thanks for doing this!

@stefan-improbable

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@aelsabbahy thanks! The tests are passing now.
As for DNS, I was thinking about using https://godoc.org/github.com/miekg/dns to spin up a DNS server in unit test resource/dns_test.go (that does not exist yet). In order to test this via Dockerfiles in integration-tests/, we could compile the test binaries via go test -c and execute them in docker. What do you think abou that?

@stefan-improbable

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@aelsabbahy

This comment has been minimized.

Copy link
Owner

commented May 23, 2019

I will merge this in as part of the next release.

I really like the idea of unit testing dns. Though not sure the value of running it in docker.

@stefan-improbable

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

I will merge this in as part of the next release.

I really like the idea of unit testing dns. Though not sure the value of running it in docker.

Thanks. I think the unit tests of DNS have lower priority for me right now given that http://dnstest.io is working now. The value of running in docker would be to test integration with different linuxes, provided goss uses libc which happens when CGO_ENABLED is set to true when building goss. But even then the value of running it in docker would not be that huge.

@aelsabbahy aelsabbahy merged commit 6ba11dc into aelsabbahy:master Jun 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.