add "kgoss" kubectl wrapper to test containers in Kubernetes #465
Conversation
|
This looks great. However, I'm keeping dgoss as the only semi-official script. By that I mean it's the only one installed by If you just remove it from install.sh, it can be treated like Maybe in the future, it can be split up into goss-extras bundle or something like that.. but for now, I'd prefer to keep them seperate. Once that's done I'll merge this. Thanks again! |
|
Thanks @aelsabbahy, glad to contribute! Working on removing the install commands and some minor touchups now. |
joshgav
force-pushed
the
kgoss-upstream
branch
from
564593a
to
9fda29b
Compare
|
Updated and rebased, tests pass, ready for merge @aelsabbahy. |
joshgav
force-pushed
the
kgoss-upstream
branch
from
9fda29b
to
1523ddc
Compare
|
Hi @aelsabbahy - I think this is ready to go, LMK if you'd like anything further. |
joshgav
force-pushed
the
kgoss-upstream
branch
from
8de4e92
to
e9ade59
Compare
|
LGTM! I'll probably merge this tomorrow along with a few other PRs. Thank you for this. I'll be opening a new issue soon tagging you and other contributors to |
|
FYI: Made a slight change to the readme after the merge |
…g#465) * add kgoss kubectl wrapper * remove kgoss from published artifacts
In my environment containers must be built and run within a Kubernetes cluster so I ported dgoss to use
kubectl [run | exec | cp] ...instead of docker and named the port "kgoss". Thought others might benefit from this too so sharing back upstream.If you want this, would love to know what your use case is and what other features you seek.
There are refinements to be made and I'd love to add an e2e test, but it seemed a good time to get feedback on the general idea and direction. Thanks!