New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#439] Add --vars-inline that is capable of overwriting --vars #534
Conversation
I'll review this over the weekend. At first glance tests/results it looks great. |
So, trying this out, and seems like there's either a bug in the code, or I'm misunderstanding it. package:
coreutils:
installed: true
I tried:
|
Oh, found the bug! seems |
Great catch! Thank you, I will address this bug as soon I have some time. I have been very busy with repairs at the new house... |
Congrats on the new house. :) |
Thank you @aelsabbahy for the patience, it's ready to be reviewed again. I finally had some uninterrupted free time to wrap my head around Goss. I abstracted the calls to load the variables and merge them and unit test it to ensure no other problems from now on. I got problems on Code Climate so I tweaked the |
Looks great, small change to env var naming and then it's ready to go.
Thanks for the great contributions!
… syntax Co-Authored-By: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com>
…ars (aelsabbahy#534) * Add --vars-inline that is capable of overwriting --vars * Reinforce the --vars-inline overwrite of --vars * Clean up the TemplateFilter based on Code Climate feedback * Fix the Travis testing by ensuring all the checks are ran * Apply suggestions from code review for incorrect environment variable syntax Co-Authored-By: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com> Co-authored-by: Ahmed Elsabbahy <aelsabbahy@users.noreply.github.com>
If I want to inline mulltiple variables , will I have to add multiple arguments like,
because, when I run
goss throws an error with |
Okay this is resolved. I had to put
|
Checklist
make test-all
(UNIX) passes. CI will also test thisDescription of change
Add
--vars-inline
to dynamically pass variables which can overwrite variables sourced from--vars
, but with no deep merging.Closes #439