Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#320] Correct Debian package discovery #535

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@pedroMMM
Copy link
Contributor

pedroMMM commented Jan 3, 2020

Checklist
  • make test-all (UNIX) passes. CI will also test this
  • unit and/or integration tests are included (if applicable)
    I am not sure how to go about testing this one. Maybe someone that has more experience Mocking in Go can help out here?

Description of change

Ensure the Debian Package Manager is targeting the correct binary.

Fixes #320

@aelsabbahy

This comment has been minimized.

Copy link
Owner

aelsabbahy commented Jan 7, 2020

LGTM! Thanks!

Haven't forgotten about your other PRs by the way.

@aelsabbahy aelsabbahy merged commit 8afe631 into aelsabbahy:master Jan 7, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aelsabbahy

This comment has been minimized.

Copy link
Owner

aelsabbahy commented Jan 7, 2020

One possible way to test this is using something like this:

https://youtu.be/_NKQX-TdNMc?t=6m38s

Or refactor and use dependency injection like a few slides before that.

Lastly, I know one of the PRs added testify package, but I'm not sure if it can mock this example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.