Make weighing process twice as fast to match speed in README #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The back end waits for 100 milliseconds between sending readings so that it doesn't overwhelm the front-end with readings and complete the weighing process too quickly. However, 100ms * 50 readings = 5 seconds which is a fair bit slower than the 3 seconds mentioned in the README. To align the weighing speed with the user's expectations from the README, halve the wait between sending readings to 50ms so that the overall process takes 2.5s.
|
This will double the stress on the front-end as you mentioned. I remember doing tests on this since a too high speed would actually make the weighing slower and skip readings. But, since its on par with the readme I guess thats about the initial speed before the back-end change. |
|
Thanks @aelveborn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The back end waits for 100 milliseconds between sending readings so that it doesn't overwhelm the front-end with readings and complete the weighing process too quickly. However, 100ms * 50 readings = 5 seconds which is a fair bit slower than the 3 seconds mentioned in the README.
To align the weighing speed with the user's expectations from the README, halve the wait between sending readings to 50ms so that the overall process takes 2.5s.