From 133e1b4de976ec79ee530966a5afeb7147896c3c Mon Sep 17 00:00:00 2001 From: hontarau Date: Fri, 29 Mar 2024 16:42:11 +0100 Subject: [PATCH] Remove unneeded deep copy --- internal/controller/factory/statefulset.go | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/internal/controller/factory/statefulset.go b/internal/controller/factory/statefulset.go index 8321f5a0..43e98129 100644 --- a/internal/controller/factory/statefulset.go +++ b/internal/controller/factory/statefulset.go @@ -238,25 +238,23 @@ func getLivenessProbe(probe *corev1.Probe) *corev1.Probe { } func mergeWithDefaultProbe(probe *corev1.Probe, defaultProbe corev1.Probe) *corev1.Probe { - res := defaultProbe.DeepCopy() - if probe == nil { - return res + return &defaultProbe } if probe.InitialDelaySeconds != 0 { - res.InitialDelaySeconds = probe.InitialDelaySeconds + defaultProbe.InitialDelaySeconds = probe.InitialDelaySeconds } if probe.PeriodSeconds != 0 { - res.PeriodSeconds = probe.PeriodSeconds + defaultProbe.PeriodSeconds = probe.PeriodSeconds } if hasProbeHandlerAction(*probe) { - res.ProbeHandler = probe.ProbeHandler + defaultProbe.ProbeHandler = probe.ProbeHandler } - return res + return &defaultProbe } func hasProbeHandlerAction(probe corev1.Probe) bool {