Make bootstrap.sh handle optional variable to set preferred RDBMS

[eggmaster]

Install dependencies for either sqlite or postgresql based on value
of FACTER_RDBMS

[cwolferh]

I think it would be preferable to only define FACTER_RDBMS_DBNAME, FACTER_RDBMS_USERNAME and FACTER_RDBMS_PASSWORD in the postgres case, i.e., wrap lines 28 to 40 inside of an if like:

if [ "x$FACTER_RDBMS" = "xpostgresql" ]; then
  ...define the three facter vars as you currently have
fi

Also, I think the FACTER_DB_USERNAME for postgres is usually going to be $USER (the current logged in user). At least, that is the pattern I have followed thus far but I am not a postgres expert.

[eggmaster]

Re: FACTER_DB_USERNAME; I think it's fine to set it to $USER as you suggest.

On the other subject (of only defining FACTER_RDBMS_DBNAME, FACTER_RDBMS_USERNAME and FACTER_RDBMS_PASSWORD in the postgres case), I had that same thought initially. But after we talked about the possibility of a third (or more) possible database backend, I thought that these variables would be generally useful (mysql and oracle both make use of these identifiers, for example).

[cwolferh]

Once we have oracle and/or mysql support, we could define FACTER_RDBMS_DBNAME, FACTER_RDBMS_USERNAME and FACTER_RDBMS_PASSWORD in those cases too... just not sure it makes sense to have those defined in the sqlite case. I'm getting a bit nitpick-y, though.

[eggmaster]

I don't have a strong preference (or at least any stronger argument for my way) so I defer to the nit-pickiness :)

[eggmaster]

amended commit to reflect the changes we've agreed on here.

[cwolferh]

Works as advertised. Tested bootstrap.sh using postgres (now the default and recommended DB) on

rhel5 with rbenv 1.9.3
rhel5 with system ruby
rhel5 with rbenv 1.8.7
rhel5 with rbenv 1.9.3 and predefined FACTER_RDBMS_DBNAME
rhel5 weith system ruby sqlite
fc17 with system ruby
fc17 with rbenv 1.8.7
fc17 with rbenv 1.9.3
ubuntu 12.04 with rbenv 1.9.3
ubuntu 12.04 with rbenv 1.8.7

Also tested sqlite (previously existing functionality) still works with rhel5 and fc17.

Nice work!