From 912a8253332a29ade01c64849bd3281e403d2bde Mon Sep 17 00:00:00 2001 From: Yusuke Tsutsumi Date: Wed, 10 Apr 2024 22:13:04 -0700 Subject: [PATCH 1/2] chore: add prettier to checklist Adding prettier to the checklist since formatting is often forgotten and can result in issues with linting, impeding cycle time to merge PRs. --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a4b7c3f0..a01bbdc9 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -24,6 +24,7 @@ contributing to this repository. - [ ] Ensure that your PR [references AEPs](https://aep.dev/style-guide#referencing-aeps) correctly. +- [ ] [My code has been formatted](https://aep.dev/contributing#formatting) (usually `prettier -w .`) ### Additional checklist for a new AEP From e964f781161ec0288585708e192de28fb4ba5df5 Mon Sep 17 00:00:00 2001 From: Yusuke Tsutsumi Date: Wed, 10 Apr 2024 22:18:30 -0700 Subject: [PATCH 2/2] adding a few more niceties - removing header since it's always below the commit description. --- .github/PULL_REQUEST_TEMPLATE.md | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a01bbdc9..331533f1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,8 @@ -## 📑 Proposed changes - + ## 🍱 Types of changes @@ -12,6 +12,7 @@ that apply_ - [ ] Enhancement - [ ] [New proposal](https://aep.dev/1#workflow) - [ ] Migrated from google.aip.dev +- [ ] Chore / Quick Fix ## 📋 Your checklist for this pull request @@ -24,10 +25,13 @@ contributing to this repository. - [ ] Ensure that your PR [references AEPs](https://aep.dev/style-guide#referencing-aeps) correctly. -- [ ] [My code has been formatted](https://aep.dev/contributing#formatting) (usually `prettier -w .`) +- [ ] [My code has been formatted](https://aep.dev/contributing#formatting) + (usually `prettier -w .`) ### Additional checklist for a new AEP + + - [ ] A new AEP **should** be no more than two pages if printed out. - [ ] Ensure that the PR is editable by maintainers. - [ ] Ensure that [File structure](https://aep.dev/style-guide#file-structure)