AEROGEAR-1006 #55

Closed
wants to merge 3 commits into
from

4 participants

@sebastienblanc
AeroGear member

No description provided.

@danbev
AeroGear member

This will be processed after the 1.0.0 release.

@matzew
AeroGear member

(general) comment: do we need JavaDoc on the param() methods ?

@danbev

Could you format this method so that it has the same number of indents as the other methods.

@danbev

Note sure if this is covered by our checkstyle but a space after the ',' is what most of the code base is using and it would be nice to consistent with that I think.

@danbev

Could you format this method so that it has the same number of indents as the other methods.

AeroGear member

well the indent seems okay for this method, can you confirm (you were maybe misleaded by the previous commit) ?

AeroGear member

Yes you are right. Sorry my mistake.

@danbev

Could you add an extra space after the ',':
return Optional.fromNullable(createInstance(parameter.getType(),routeContext.getRequest().getHeader(parameter.getName())));

@danbev
AeroGear member

+1

@kborchers

👍

@danbev
AeroGear member

Merged in 33b9d6f

@danbev danbev closed this Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment