Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak refresh token is simplier in 1.1 #22

Merged

Conversation

corinnekrych
Copy link
Contributor

To test:
on 'shoot-realm' (https://github.com/aerogear/aerogear-backend-cookbook/blob/master/Shoot/configuration/shoot-realm.json#L3) add:
"accessTokenLifespan": 30,
"ssoSessionIdleTimeout": 120,
to shorten default value: exp time for access token 30s and refresh token exp time: 2mins

  1. upload a photo to KC for first time (do authz flow)
  2. wait 30s (but before 2mins), upload a photo, the token is refreshed transparently without prompting the user
  3. wait 2 mins, upload a photo, the user is prompted to go to authz flow again

Note: this PR required KC1.1

@abstractj @cvasilak mind to review?

@abstractj
Copy link
Contributor

@corinnekrych I think we should update our README file mentioning that KC 1.1 is required?

@matzew
Copy link
Contributor

matzew commented Feb 23, 2015

what happens if the lib is ran against KC 1.0. ?

@corinnekrych
Copy link
Contributor Author

Keycloak expiration date is not found.
Therefore transparent refresh will not happen, user will be re-prompted for grant.
@matzew tbh I think it's still acceptable.

@matzew
Copy link
Contributor

matzew commented Feb 23, 2015

@corinnekrych that's cool, but I agree w/ @abstractj we should mention that in README and also in the release notes

@corinnekrych
Copy link
Contributor Author

+1, let me add a note in README

@corinnekrych
Copy link
Contributor Author

@matzew more details added

@matzew
Copy link
Contributor

matzew commented Feb 24, 2015

@corinnekrych perfect!

@cvasilak
Copy link
Contributor

tested on keycloak 1.1 worked as expected 👍

@corinnekrych
Copy link
Contributor Author

@abstractj ok to merge?

@abstractj
Copy link
Contributor

On it.... 🏃

@abstractj abstractj merged commit bffb360 into aerogear:master Feb 25, 2015
@abstractj
Copy link
Contributor

@corinnekrych landed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants